Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequoia-sq: new port, an OpenPGP implementation #26281

Merged
merged 1 commit into from
Oct 25, 2024
Merged

sequoia-sq: new port, an OpenPGP implementation #26281

merged 1 commit into from
Oct 25, 2024
+563 −0

Conversation

neverpanic
Copy link
Member

@neverpanic neverpanic commented Oct 23, 2024 •
edited
Loading

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 14.7 23H124 arm64
Xcode 16.0 16A242d

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick? False positives only
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vs install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot macportsbot added type: submission by: member Created by a member with commit rights labels Oct 23, 2024
herbygillot
herbygillot reviewed Oct 24, 2024
View reviewed changes
security/sequoia-sq/Portfile
depends_lib-append \
port:libiconv \
port:nettle \
port:openssl3 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this perhaps be the openssl portgroup instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to build fine as-is, so I'm not sure I actually need all the 266 lines of Tcl complexity introduced by the openssl PortGroup?

@neverpanic
Copy link
Member Author

Merging for now, we can always improve later.

@neverpanic neverpanic merged commit 264ca2d into macports:master Oct 25, 2024
4 checks passed
@neverpanic neverpanic deleted the cal-sequoia-sq branch October 25, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herbygillot herbygillot herbygillot left review comments

Assignees
No one assigned
Labels
by: member Created by a member with commit rights type: submission
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neverpanic @herbygillot @macportsbot