Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always show both stdout and stderr for code blocks #189

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Always show both stdout and stderr for code blocks #189

wants to merge 4 commits into from

Commits on Sep 17, 2022

  1. Fix imports in model.go 

    I noticed that the non-stdlib imports were split into 2 groups, seemingly
randomly. No other file does this so I just brought it back to one group
and let goimports sort it.
    @mmlb
    mmlb committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    2a0aea8 View commit details
    Browse the repository at this point in the history

  2. code: Always display the output of code blocks 

    Any output that is printed may still be useful even if the command returns
an error so lets display it. Printing out even in case of error is fine,
if there's no output and output.Write handles that fine. I tested this by
trying to run a code block for a language I do not have the compiler for.
    @mmlb
    mmlb committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    9035d62 View commit details
    Browse the repository at this point in the history

  3. code: Show both stdout and stderr 

    Code blocks may try to print to stderr which is currently dropped.
    @mmlb
    mmlb committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    8ae6fd2 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. wip

    @mmlb
    mmlb committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    1e8677d View commit details
    Browse the repository at this point in the history