Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hook in interpolations #271

Merged
merged 4 commits into from
Nov 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .ci/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def main():
if not args.pr_url_body.endswith("/"):
args.pr_url_body += "/"
url = "%s%s" % (args.pr_url_body, args.pr_number)
qa_cmd_prefix += ["--out-url", url]
#qa_cmd_prefix += ["--out-url", url]

if args.render and check_type == CheckType.NEW_FAMILY:
print(f"Rendering new family: {directory}")
Expand All @@ -123,11 +123,11 @@ def main():

elif check_type == CheckType.NEW_FAMILY:
print(f"Checking new family: {directory}")
subprocess.run(qa_cmd_prefix + ["--fontbakery"])
subprocess.run(qa_cmd_prefix + ["--fontbakery", "--interpolations"])

elif check_type == CheckType.MODIFIED_FAMILY:
print(f"Checking modified family: {directory}")
subprocess.run(qa_cmd_prefix + ["-gfb", "--fontbakery", "--diffenator"])
subprocess.run(qa_cmd_prefix + ["-gfb", "--fontbakery", "--diffenator", "--interpolations"])

elif check_type == CheckType.MODIFIED_FAMILY_METADATA:
print(f"Checking modified family metadata: {directory}")
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ jobs:
run: |
pip install --upgrade pip
pip install --pre fontbakery[googlefonts]
pip install gftools[qa] pytest
pip install "gftools[qa] @ git+https://github.com/googlefonts/gftools@qa-mm"
shell: bash

- name: Run Diffenator and Fontbakery
Expand Down
Binary file modified ofl/mavenpro/MavenPro[wght].ttf
Binary file not shown.