add gokart.testing.assert_frame_equal #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirosassa
requested changes
Nov 3, 2021
vaaaaanquish
approved these changes
Nov 4, 2021
Hi-king
requested changes
Nov 5, 2021
|
@mski-iksm thx I've understand functionalities! IMO, how about more descriptive name indicating difference (e.g. assert_frame_contents_equal, assert_frame_equal_ignoring_index) |
I agree with your idea. I've changed the method name assert_frame_equal -> assert_frame_contents_equal . Please review. |
Hi-king
approved these changes
Nov 16, 2021
|
@mski-iksm 🆒 LGTM! |
|
@mski-iksm Thx for cool function :) Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a new feature
gokart.testing.assert_frame_equal()for comparing pd.DataFrame.As mentioned in the issue, this is useful when index/columns orders are different.
Related issue: #243 raised by @vaaaaanquish
Please review!