Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lastpass source #1083

Merged
merged 23 commits into from
Apr 17, 2023
Merged

Add Lastpass source #1083

merged 23 commits into from
Apr 17, 2023

Conversation

jychp
Copy link
Collaborator

@jychp jychp commented Jan 13, 2023

This source will pull users from Lastpass

Only one new node:

  • Lastpass

It uses Human as pivot with other modules (GSuite, GitHub, HiBob ...)

@jychp
Copy link
Collaborator Author

jychp commented Jan 31, 2023

@ramonpetgrave64 ready for merge :)

achantavy
achantavy requested changes Feb 2, 2023
View reviewed changes
cartography/data/jobs/analysis/lastpass_human_link.json Outdated Show resolved Hide resolved
cartography/intel/lastpass/schema.py Outdated Show resolved Hide resolved
cartography/intel/lastpass/users.py Outdated Show resolved Hide resolved
cartography/intel/lastpass/users.py Outdated Show resolved Hide resolved
cartography/intel/lastpass/users.py Outdated Show resolved Hide resolved
docs/root/modules/lastpass/config.md Show resolved Hide resolved
@jychp jychp mentioned this pull request Feb 2, 2023
Closed
@jychp
Copy link
Collaborator Author

jychp commented Feb 14, 2023 via email •
edited
Loading

@jychp
Copy link
Collaborator Author

jychp commented Mar 1, 2023

@achantavy

I migrate to new model architecture, but not sure how auto_cleanup work, so I kept the old way.

@jychp jychp requested a review from achantavy March 31, 2023 13:04
@jychp
Copy link
Collaborator Author

jychp commented Mar 31, 2023

@achantavy this PR should be ready for new model, waiting for you comments before working on other ones

achantavy
achantavy requested changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@achantavy achantavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Left comments on some function signature changes and using cartography.client.core.tx.load. It's looking good!

cartography/intel/lastpass/users.py Outdated Show resolved Hide resolved
cartography/intel/lastpass/users.py Outdated Show resolved Hide resolved
cartography/intel/lastpass/users.py Outdated Show resolved Hide resolved
cartography/intel/lastpass/users.py Show resolved Hide resolved
ramonpetgrave64
ramonpetgrave64 suggested changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@ramonpetgrave64 ramonpetgrave64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a couple test cases to add.

cartography/intel/lastpass/users.py Show resolved Hide resolved
tests/integration/cartography/intel/lastpass/test_users.py Outdated Show resolved Hide resolved
tests/integration/cartography/intel/lastpass/test_users.py Outdated Show resolved Hide resolved
@jychp
Copy link
Collaborator Author

jychp commented Apr 14, 2023

@achantavy @ramonpetgrave64 changes made

achantavy
achantavy reviewed Apr 15, 2023
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@achantavy achantavy closed this Apr 17, 2023
@achantavy achantavy reopened this Apr 17, 2023
@achantavy
Copy link
Contributor

Thank you @resilience-jychp !

@achantavy achantavy merged commit 588de92 into lyft:master Apr 17, 2023
@jychp jychp deleted the lastpass_intel branch May 29, 2023 08:01
chandanchowdhury pushed a commit to juju4/cartography that referenced this pull request Jun 26, 2024
@jychp @chandan-cl
Add Lastpass support (lyft#1083)
d9af8c6 
This source will pull users from Lastpass

It uses Human as pivot with other modules (GSuite, GitHub, HiBob ...)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonpetgrave64 ramonpetgrave64 ramonpetgrave64 approved these changes

@achantavy achantavy achantavy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jychp @achantavy @ramonpetgrave64