Prefer Hostname in AD CS Web API URL #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtpt-erikgeiser
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a certificate is requested with
-web, the AD CS web API is currently accessed using IP addresses with the hostname in the host header. This can sometimes fail, probably because IIS checks the TLS-SNI instead of the host header depending on the configuration. With this PR, the hostname is used in the url passed torequestssuch that the TLS-SNI can be set accordingly. As I understand it,self.target.remote_namecontains the IP if the hostname cannot be determined, so it should not break anything.