Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer from konsole, prohibit to look up the historical information with the middle mouse scrolling #462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ch593030323
Copy link

Refer from konsole, prohibit to look up the historical information with the middle mouse scrolling

@yan12125
Copy link
Member

yan12125 commented Mar 6, 2022

Some notes at the first glance:

@ch593030323
Copy link
Author

ch593030323 commented Apr 28, 2022

Thank for ur suggestion.
Sorry to long time no reply in advance. I have updated the PR.17fb53e
There are some urls and descriptions to clear some idea of new code in the commit message.

@ch593030323 ch593030323 reopened this Apr 28, 2022
@ch593030323
Copy link
Author

ch593030323 commented Apr 29, 2022

About #260, the PR is one kind of solution.
Konsole url can be found in commit messgae.
Comments of chinese have removed.

Copy link
Member

@yan12125 yan12125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! This pull request is almost ready. Here is a minor issue. Also don't change indentation. They will be handled in #473.

getCharacterPosition( ev->position() , charLine , charColumn );
int charLine;
int charColumn;
getCharacterPosition( ev->pos() , charLine , charColumn );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pos() is deprecated. Please change it back to position().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants