Add word characters preference option (fixes #1098) #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Whoops. I found a bug in this PR: When the preference is changed, it isn't saved to disk, so it only persists as long as QTerminal is running. I only noticed this because I rebooted yesterday. I'll get a fix in later once I have time to sit down with it when I'm not at work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gnome-terminal supports configuring word selection characters, but QTerminal doesn't. This PR adds a configuration option to address that shortcoming.
I was going to make a feature request, but I found this feature request that beat me to it. @yan12125 had a partial implementation that I referenced, but I discovered that it was going to require a change to QTermWidget as well.
QTermWidget dependency: lxqt/qtermwidget#531