-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI for custom screenlocker on x11 #517
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somes changes are needed here, IMO.
The custom screen-locker command should not be allowed to be empty.
__userfile__=true
lock_command=
It enabled status should be controlled by a Use custom screen locker
checkbox.
xss-lock
is not a screen locker. It's a tool to helper to use another locker
From the documentation:
xss-lock - use external locker as X screen saver xss-lock hooks up your favorite locker to the MIT screen saver extension for X and also to systemd's login manager.
By itself it's useless.
With some help from @tsujan done. |
Testing it |
@luis-pereira Updates? |
There can arise a situation when the user has xscreensaver enabled in autostart, enabled screenlocking in it and uses also a custom screenlocker:
Maybe we could add a tooltip "Make sure no xdg-screensaver compatible screensaver like xscreensaver is running at the same time" or similar. |
Needs lxqt/liblxqt#346
Settings go to
session.conf
which is more natural as also the delay is here and it is about session locking. The PR above checks for backward compatibility firstlxqt.conf
.We could also remove the "custom" and use
xdg-screensaver lock
as empty/default value.In the list I added all screenlockers from here, except AUR.
Window Manager → X11 Window Manager