Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI for custom screenlocker on x11 #517

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stefonarch
Copy link
Member

@stefonarch stefonarch commented May 25, 2024

Needs lxqt/liblxqt#346

Settings go to session.conf which is more natural as also the delay is here and it is about session locking. The PR above checks for backward compatibility first lxqt.conf.

[General]
__userfile__=true
leave_confirmation=false
lock_command=slock
lock_screen_before_power_actions=true
power_actions_after_lock_delay=2250
window_manager=kwin_x11

We could also remove the "custom" and use xdg-screensaver lock as empty/default value.

In the list I added all screenlockers from here, except AUR.

Window Manager → X11 Window Manager

Copy link
Member

@luis-pereira luis-pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somes changes are needed here, IMO.

The custom screen-locker command should not be allowed to be empty.
screen-2024-05-28-18-40-51

__userfile__=true
lock_command=

It enabled status should be controlled by a Use custom screen locker checkbox.

xss-lock is not a screen locker. It's a tool to helper to use another locker
From the documentation:
xss-lock - use external locker as X screen saver xss-lock hooks up your favorite locker to the MIT screen saver extension for X and also to systemd's login manager.

By itself it's useless.

@stefonarch
Copy link
Member Author

With some help from @tsujan done.

@luis-pereira
Copy link
Member

Testing it

@stefonarch
Copy link
Member Author

@luis-pereira Updates?

@stefonarch
Copy link
Member Author

stefonarch commented Jul 16, 2024

There can arise a situation when the user has xscreensaver enabled in autostart, enabled screenlocking in it and uses also a custom screenlocker:

  • clicking "lock screen" the custom one is executed
  • when "lock screen before suspend" is checked xscreensaver's lockscreen appears at awake and after unlocking the message "could not execute slock, make sure it's installed etc" is shown.

Maybe we could add a tooltip "Make sure no xdg-screensaver compatible screensaver like xscreensaver is running at the same time" or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants