Guarantee that theme name is name of theme folder #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't guaranteed after considering theme names case-insensitively (→ #308). After this change, other components won't need to be aware of case-insensitivity of theme names.
tsujan
added a commit
to lxqt/lxqt-config
that referenced
this pull request
Apr 24, 2022
Previously, the value of the "theme" key was used, which may differ in letter cases from the current theme name. This PR requires and depends on lxqt/liblxqt#309.
tsujan
added a commit
to lxqt/lxqt-config
that referenced
this pull request
Apr 25, 2022
Previously, the value of the "theme" key was used, which may differ in letter cases from the current theme name. Also, the themes list is sorted alphabetically. Previously, the user themes came first. This PR requires and depends on lxqt/liblxqt#309.
|
This simple change was needed after #308. Any objection to merging? |
This was referenced Apr 30, 2022
|
Closing. See #310 for the reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't guaranteed after considering theme names case-insensitively (→ #308).
After this change, other components won't need to be aware of case-insensitivity of theme names.