Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

Handle boolean properties properly #490

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

bodgix
Copy link

@bodgix bodgix commented Feb 16, 2018

This commit fixes a bug where boolean properties
of the `instance’ resource were getting overriden
by default values when they were set to false.

Fixes #489

Signed-off-by: Bogdan Katynski [email protected]

This commit fixes a bug where boolean properties
of the `instance’ resource were getting overriden
by default values when they were set to false.

Fixes lusis#489

Signed-off-by: Bogdan Katynski <[email protected]>
After adding some extra logic to handle boolean
parameters, RuboCop AbcSize and PerceivedComplexity
cops started alarming.

Disabling them for the load_current_resource method.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean properties are overriden by default values when set to false
1 participant