feat: allow endingTimestamp to be 0

[b00ste]

What does this PR introduce?

🚀 Feature

Allow the validity timestamp in a relay call to start but never end

PR Checklist

• Wrote Tests
• Wrote & Generated Documentation (readme/natspec/dodoc)
• Ran npm run lint && npm run lint:solidity (solhint)
• Ran npm run format (prettier)
• Ran npm run build
• Ran npm run test

[Hugoo]

Task linked: DEV-7978 Allow to not specify deadline in validityTimestamp

[github-actions]

👋 Hello
⛽ I am the Gas Bot Reporter. I keep track of the gas costs of common interactions using Universal Profiles 🆙 !
📊 Here is a summary of the gas cost with the code introduced by this PR.

⛽📊 See Gas Benchmark report of Using UniversalProfile owned by an EOA

🔀 execute scenarios

execute scenarios - 👑 UP Owner	⛽ Gas Usage
Transfer 1 LYX to an EOA without data	37537
Transfer 1 LYX to a UP without data	36639
Transfer 1 LYX to an EOA with 256 bytes of data	42210
Transfer 1 LYX to a UP with 256 bytes of data	44843
Transfer 0.1 LYX to 3x EOA without data	70862
Transfer 0.1 LYX to 3x UP without data	75680
Transfer 0.1 LYX to 3x EOA with 256 bytes of data	84802
Transfer 0.1 LYX to 3x EOA with 256 bytes of data	100357

🗄️ setData scenarios

setData scenarios - 👑 UP Owner	⛽ Gas Usage
Set a 20 bytes long value	49971
Set a 60 bytes long value	95281
Set a 160 bytes long value	164465
Set a 300 bytes long value	279700
Set a 600 bytes long value	484124
Change the value of a data key already set	32859
Remove the value of a data key already set	27333
Set 2 data keys of 20 bytes long value	78428
Set 2 data keys of 100 bytes long value	260568
Set 3 data keys of 20 bytes long value	105145
Change the value of three data keys already set of 20 bytes long value	45445
Remove the value of three data keys already set	41339

🗄️ Tokens scenarios

Tokens scenarios - 👑 UP Owner	⛽ Gas Usage
Minting a LSP7Token to a UP (No Delegate) from an EOA	92016
Minting a LSP7Token to an EOA from an EOA	59323
Transferring an LSP7Token from a UP to another UP (No Delegate)	100102
Minting a LSP8Token to a UP (No Delegate) from an EOA	158946
Minting a LSP8Token to an EOA from an EOA	126253
Transferring an LSP8Token from a UP to another UP (No Delegate)	148671

📝 Notes

• The execute and setData scenarios are executed on a fresh UniversalProfile smart contract, deployed as standard contracts (not as proxy behind a base contract implementation).

⛽📊 See Gas Benchmark report of Using UniversalProfile owned by an LSP6KeyManager

This document contains the gas usage for common interactions and scenarios when using UniversalProfile smart contracts.

🔀 execute scenarios

👑 unrestricted controller

execute scenarios - 👑 main controller	⛽ Gas Usage
transfer LYX to an EOA	60475
transfer LYX to a UP	62077
transfer tokens (LSP7) to an EOA (no data)	107995
transfer tokens (LSP7) to a UP (no data)	244451
transfer a NFT (LSP8) to a EOA (no data)	171864
transfer a NFT (LSP8) to a UP (no data)	291567

🛃 restricted controller

execute scenarios - 🛃 restricted controller	⛽ Gas Usage
transfer some LYXes to an EOA - restricted to 1 x allowed address only (TRANSFERVALUE + 1x AllowedCalls)	71667
transfers some tokens (LSP7) to an EOA - restricted to LSP7 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data)	122686
transfers some tokens (LSP7) to an other UP - restricted to LSP7 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data)	259142
transfers a NFT (LSP8) to an EOA - restricted to LSP8 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data)	186520
transfers a NFT (LSP8) to an other UP - restricted to LSP8 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data)	306223

🗄️ setData scenarios

👑 unrestricted controller

setData scenarios - 👑 main controller	⛽ Gas Usage
updates profile details (LSP3Profile metadata)	136898
give permissions to a controller (AddressPermissions[] + AddressPermissions[index] + AddressPermissions:Permissions:)	133033
restrict a controller to some specific ERC725Y Data Keys	139305
restrict a controller to interact only with 3x specific addresses	162009
remove a controller (its permissions + its address from the AddressPermissions[] array)	68012
write 5x LSP12 Issued Assets	233276

🛃 restricted controller

setData scenarios - 🛃 restricted controller	⛽ Gas Usage
setData(bytes32,bytes) -> updates 1x data key	102799
setData(bytes32[],bytes[]) -> updates 3x data keys (first x3)	161538
setData(bytes32[],bytes[]) -> updates 3x data keys (middle x3)	145692
setData(bytes32[],bytes[]) -> updates 3x data keys (last x3)	171025
setData(bytes32[],bytes[]) -> updates 2x data keys + add 3x new controllers (including setting the array length + indexes under AddressPermissions[index])	251024

📝 Notes

• The execute and setData scenarios are executed on a fresh UniversalProfile and LSP6KeyManager smart contracts, deployed as standard contracts (not as proxy behind a base contract implementation).

[github-actions]

Changes to gas cost

Generated at commit: d3a169c98e3e774de7083721b1d61052bcb222e2, compared to commit: b8eca3c5696acf85239130ef67edec9e8c134bfa

🧾 Summary (10% most significant diffs)

Contract	Method	Avg (+/-)	%
LSP6ExecuteRestrictedController	lsp20VerifyCall transferLYXToEOA transferLYXToUP transferTokensToRandomEOA	-214 ✅ -147 ✅ -147 ✅ -157 ✅	-1.26% -0.26% -0.47% -0.21%
LSP6ExecuteUnrestrictedController	lsp20VerifyCall transferLYXToEOA transferLYXToUP transferTokensToRandomEOA	-214 ✅ -147 ✅ -147 ✅ -157 ✅	-1.26% -0.26% -0.44% -0.22%
LSP6SetDataRestrictedController	execute givePermissionsToController restrictControllerToERC725YKeys	-160 ✅ +192 ❌ +192 ❌	-0.56% +0.16% +0.14%
LSP6SetDataUnrestrictedController	execute givePermissionsToController	-160 ✅ +192 ❌	-0.56% +0.15%

---

Full diff report 👇

Contract	Deployment Cost (+/-)	Method	Min (+/-)	%	Avg (+/-)	%	Median (+/-)	%	Max (+/-)	%	# Calls (+/-)
LSP6ExecuteRestrictedController	2,862,894 (-12,797)	lsp20VerifyCall transferLYXToEOA transferLYXToUP transferNFTToRandomEOA transferNFTToRandomUP transferTokensToRandomEOA transferTokensToRandomUP	14,619 (-277) 56,018 (-147) 31,349 (-147) 130,724 (-45) 239,224 (-90) 73,535 (-157) 208,947 (-212)	-1.86% -0.26% -0.47% -0.03% -0.04% -0.21% -0.10%	16,818 (-214) 56,018 (-147) 31,349 (-147) 130,724 (-45) 239,224 (-90) 73,535 (-157) 208,947 (-212)	-1.26% -0.26% -0.47% -0.03% -0.04% -0.21% -0.10%	17,551 (-194) 56,018 (-147) 31,349 (-147) 130,724 (-45) 239,224 (-90) 73,535 (-157) 208,947 (-212)	-1.09% -0.26% -0.47% -0.03% -0.04% -0.21% -0.10%	17,551 (-194) 56,018 (-147) 31,349 (-147) 130,724 (-45) 239,224 (-90) 73,535 (-157) 208,947 (-212)	-1.09% -0.26% -0.47% -0.03% -0.04% -0.21% -0.10%	8 (0) 1 (0) 1 (0) 1 (0) 1 (0) 1 (0) 1 (0)
LSP6ExecuteUnrestrictedController	2,862,894 (-12,797)	lsp20VerifyCall transferLYXToEOA transferLYXToUP transferNFTToRandomEOA transferNFTToRandomUP transferTokensToRandomEOA transferTokensToRandomUP	14,619 (-277) 56,648 (-147) 33,349 (-147) 129,472 (-46) 237,973 (-90) 71,971 (-157) 207,383 (-212)	-1.86% -0.26% -0.44% -0.04% -0.04% -0.22% -0.10%	16,818 (-214) 56,648 (-147) 33,349 (-147) 129,472 (-46) 237,973 (-90) 71,971 (-157) 207,383 (-212)	-1.26% -0.26% -0.44% -0.04% -0.04% -0.22% -0.10%	17,551 (-194) 56,648 (-147) 33,349 (-147) 129,472 (-46) 237,973 (-90) 71,971 (-157) 207,383 (-212)	-1.09% -0.26% -0.44% -0.04% -0.04% -0.22% -0.10%	17,551 (-194) 56,648 (-147) 33,349 (-147) 129,472 (-46) 237,973 (-90) 71,971 (-157) 207,383 (-212)	-1.09% -0.26% -0.44% -0.04% -0.04% -0.22% -0.10%	8 (0) 1 (0) 1 (0) 1 (0) 1 (0) 1 (0) 1 (0)
LSP6SetDataRestrictedController	2,847,670 (-12,798)	execute givePermissionsToController restrictControllerToERC725YKeys	18,343 (-147) 120,826 (+192) 139,076 (+192)	-0.80% +0.16% +0.14%	28,375 (-160) 120,826 (+192) 139,076 (+192)	-0.56% +0.16% +0.14%	28,375 (-160) 120,826 (+192) 139,076 (+192)	-0.56% +0.16% +0.14%	38,408 (-173) 120,826 (+192) 139,076 (+192)	-0.45% +0.16% +0.14%	2 (0) 1 (0) 1 (0)
LSP6SetDataUnrestrictedController	2,847,670 (-12,798)	execute givePermissionsToController restrictControllerToERC725YKeys	18,343 (-147) 126,826 (+192) 147,576 (+192)	-0.80% +0.15% +0.13%	28,375 (-160) 126,826 (+192) 147,576 (+192)	-0.56% +0.15% +0.13%	28,375 (-160) 126,826 (+192) 147,576 (+192)	-0.56% +0.15% +0.13%	38,408 (-173) 126,826 (+192) 147,576 (+192)	-0.45% +0.15% +0.13%	2 (0) 1 (0) 1 (0)