Fix failed specs in Crystal v1.13 #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
Failures:
1) Lucky::CookieJar raises a nicer error for invalid cookie values
Failure/Error: expect_raises(Lucky::InvalidCookieValueError, "Cookie value for 'cookie' is invalid") do
Expected Lucky::InvalidCookieValueError but nothing was raised
Error: # spec/lucky/cookies/cookie_jar_spec.cr:41
```
Crystal v1.13 accepts space in cookie values as valid.
See <crystal-lang/crystal#14455>.
|
There's also crystal-loot/exception_page#49, which breaks Lucky when using |
|
Is this the right code? It looks like #1908 ? 🤔 |
|
oohh... I see where the change was made. Ok. Yeah, looks like the other one snuck in here 😂 |
jwoertink
reviewed
Aug 12, 2024
| @@ -35,7 +35,7 @@ describe Lucky::CookieJar do | |||
| end | |||
|
|
|||
| it "raises a nicer error for invalid cookie values" do | |||
| value = "Double Chocolate" | |||
| value = "Double,Chocolate" | |||
|
Oops, sorry! I forgot to checkout |
|
I can close this and send a new PR if that is preferred? |
|
It's ok. I was going to merge the other anyway, so we'll just lump them together :D |
jwoertink
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix failed
Lucky::CookieJarspecs in Crystal v1.13Description
Lucky::CookieJarspecs fail in Crystal v1.13. This is related to crystal-lang/crystal#14455. This PR fixes that.See https://github.com/luckyframework/lucky/actions/runs/10340714956/job/28621689266.
Checklist
crystal tool format spec src./script/setup./script/test