Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 compability #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

PHP 8 compability #27

wants to merge 4 commits into from

Conversation

kawakibi
Copy link

@kawakibi kawakibi commented Nov 24, 2021

  • PHP 8 has internal changes in TSRM, some are removed ( PHP 8 Upgrading internals)
  • Arginfo now mandatory. There are missing arginfo for MogileFs ( Mandatory arginfo )
  • new file mogilefs.stub.php for automatically building arginfo for php 8 (using gen_stub.php)
  • separate arginfo file for PHP 8 (mogilefs_arginfo.h) and PHP 7 (mogilefs_legacy_arginfo.h)
  • move old test to *_7.php for PHP 7
  • new tests file for php 8

Tested on :

  1. PHP 8.0.10
  2. PHP 7.4.26

NaufalFakhriKaskus and others added 4 commits September 3, 2021 13:45
* PHP 8 compability
- rebuild arginfo with __construct
- change type_hint "integer" to int on some methods (using integer triggers warning)
- update test

* PHP 7 backward compability
- add separate test for php 7
- add legacy arginfo file for php 7

* bump to dev version

* change test decription for mogileFs::fileInfo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant