Add note configuration parameter to close_loop_comcam.py script
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edennihy
approved these changes
Oct 8, 2024
| @@ -175,6 +175,12 @@ def get_schema(cls) -> typing.Dict[str, typing.Any]: | |||
| - type: string | |||
| - type: "null" | |||
| default: null | |||
| note: | |||
| description: Optional note for taking the data. | |||
There was a problem hiding this comment.
Please update the description to be consistent with how note is defined in other data taking scripts e.g.
gmegh
force-pushed
the
tickets/DM-46695
branch
from
1a15353
to
7cb917e
Compare
gmegh
force-pushed
the
tickets/DM-46695
branch
from
7cb917e
to
2789781
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.