Tickets/dm 45817 #221
Tickets/dm 45817 #221
Conversation
dsanmartim
force-pushed
the
tickets/DM-45817
branch
from
012c3b6
to
ae94004
Compare
| @@ -78,6 +78,18 @@ def get_schema(cls): | |||
| v: | |||
| type: number | |||
| description: Ry offset (deg). | |||
| reset_axis: | |||
There was a problem hiding this comment.
I think the naming here is backwards, reset_only should be the boolean and reset_axis the name of the axis you want to reset.
There was a problem hiding this comment.
For the reset_only property, I focused on giving flexibility to reset any axis the user may want, instead of resetting all of them (which would be the case if this is a boolean). For the reset_axis (to reset axis before doing offset), maybe this property should be called reset_first to be more intuitive.
There was a problem hiding this comment.
I refactored the code to have only the reset_axis property to deal with all possible scenarios to reset the axes. Thanks for your suggestions!
dsanmartim
force-pushed
the
tickets/DM-45817
branch
5 times, most recently
from
4f4fa12
to
a945cc9
Compare
doc/news/DM-45817.feature.rst
Outdated
| @@ -0,0 +1,3 @@ | |||
| In ``offset_camera_hexapod.py``and ``offset_m2_hexapod.py``: | |||
There was a problem hiding this comment.
need a space between ```offset_camera_hexapod.py``and`
doc/news/DM-45817.feature.rst
Outdated
| @@ -0,0 +1,3 @@ | |||
| In ``offset_camera_hexapod.py``and ``offset_m2_hexapod.py``: | |||
| - add an option to reset hexapod offsets to zero. In this case, it only reset offset and don't do anything else. | |||
There was a problem hiding this comment.
Please, use semantic line breaking and capitalize the "a" in "Add"
doc/news/DM-45817.feature.rst
Outdated
| @@ -0,0 +1,3 @@ | |||
| In ``offset_camera_hexapod.py``and ``offset_m2_hexapod.py``: | |||
| - add an option to reset hexapod offsets to zero. In this case, it only reset offset and don't do anything else. | |||
| - add an option to reset hexapod offsets before applying new offsets. In this case, it reset offset before applying new offsets. | |||
There was a problem hiding this comment.
Please, use semantic line breaking and capitalize the "a" in "Add"
There was a problem hiding this comment.
Tks. The messages were really bad actually. I just improved them, taking your suggestions into account.
dsanmartim
force-pushed
the
tickets/DM-45817
branch
2 times, most recently
from
5f6e5e4
to
a04856e
Compare
dsanmartim
force-pushed
the
tickets/DM-45817
branch
from
a04856e
to
0d61e26
Compare
Hi @tribeiro
I implemented this in a way that maintains backward compatibility, ensuring the script continues to work in the same way in existing json blocks.