-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new move_rotator.py
SAL Script
#146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, see my inline comment.
python/lsst/ts/standardscripts/maintel/mtrotator/move_rotator.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.. Take a look at my comments before merging please!
|
||
""" | ||
|
||
def __init__(self, index: int, add_remotes: bool = True) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove the add_remotes
parameter now.
await self.mtcs.move_rotator( | ||
angle=self.target_angle, wait_for_complete=self.wait_for_complete | ||
) | ||
if self.wait_for_complete: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand why you included this checkpoints here. Is the idea to provide a way for people to pause the script? I suggest you change it to be a single message, regardless of the value of self.wait_for_complete
. Maybe something like:
await self.checkpoint(f"Move rotator finished.")
Or, if you want to provide information about the wait_for_complete
, something like this:
await self.checkpoint(f"Move rotator finished; wait for complete: {self.wait_for_complete}.")
* Remove ``add_remotes`` argument from ``MoveRotator.__init__`` * Squeeze the checkpoints at the end to be a single line
f50ea8c
to
cf64040
Compare
* Remove ``add_remotes`` argument from ``MoveRotator.__init__`` * Squeeze the checkpoints at the end to be a single line
85a1d00
to
f850799
Compare
f850799
to
79ae437
Compare
Add the new
move_rotator.py
SAL Script. This depends on lsst-ts/ts_observatory_control#107.