-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ability to ignore actuators #133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the version history and take a look at the inline comments I've made.
I think this can be a new patch release, e.g.; v1.24.2
The CI is failing because of the indentation problem I mention on the schema (line 139).
items: | ||
type: number | ||
enum: [{m1m3_actuator_ids_str}] | ||
default: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is line ha the wrong indentation level. It should be one level up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw it just after opening the PR. Already fixed it.
if config.ignore_actuators: | ||
self.actuators_to_test = list( | ||
filter( | ||
lambda actuator: actuator not in config.ignore_actuators, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lambda functions are not allowed per our development guidelines: https://developer.lsst.io/python/style.html#lambda-should-not-be-used
I would suggest doing something like:
self.actuators_to_test = [actuator_id for actuator_id in self.actuators_to_test if actuator_id not in config.ignore_actuators]
It is more clear and expressive than the implementation here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! thanks for the updates! please, squash your commits before merging.
c1d9ffb
to
a0bd48d
Compare
Tks for approving it. Merged! |
Hi Tiago,
I did a quick implementation on this ticket. Can you take a look on the first try and tell me if anything else would be needed?