DM-39207-- Power Off ATCalSys #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isotuela
force-pushed
the
tickets/DM-39207
branch
3 times, most recently
from
ba35369
to
30777b5
Compare
tribeiro
reviewed
Jul 18, 2023
|
|
||
|
|
||
| class PowerOffATCalSys(salobj.BaseScript): | ||
| """Powers on the ATCalSys dome flat illuminator |
| f"Lamp state: {ATWhiteLight.LampBasicState(lamp_state.basicState)!r}." | ||
| f"Need to wait {cool_down_wait_time/60} min" | ||
| ) | ||
| asyncio.sleep(60) |
| ------ | ||
| RunTimeError: | ||
| If ATWhiteLight is not ENABLED""" | ||
| for comp in [self.white_light_source]: |
There was a problem hiding this comment.
It's only one component.. You can probably skip the for loop.
| RunTimeError: | ||
| If ATWhiteLight is not ENABLED""" | ||
| for comp in [self.white_light_source]: | ||
| summary_state = await comp.evt_summaryState.aget() |
There was a problem hiding this comment.
Make sure you add a timeout to aget or it can block here for ever if there's missing data.
| If ATWhiteLight is not ENABLED""" | ||
| for comp in [self.white_light_source]: | ||
| summary_state = await comp.evt_summaryState.aget() | ||
| if salobj.State(summary_state.summaryState) != salobj.State( |
There was a problem hiding this comment.
You don't need to cast neither values:
if summary_state.summaryState != salobj.State.ENABLED:
...
e28128c
to
75728e9
Compare
tribeiro
reviewed
Jul 18, 2023
|
|
||
| async def switch_lamp_off(self): | ||
| """Switches white light source lamp off""" | ||
| await self.white_light_source.evt_lampState.flush() |
There was a problem hiding this comment.
Flush is not a coroutine, remove await
isotuela
force-pushed
the
tickets/DM-39207
branch
from
b01c515
to
8558600
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.