DM-45331: Manage cases when yesterday's movie needs to be picked up immediately #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugyballoons
force-pushed
the
tickets/DM-45331
branch
from
e1b126f
to
16419af
Compare
sebastian-aranda
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Good job @ugyballoons ! I left some minor comments, but this looks good to me 👍.
ugyballoons
force-pushed
the
tickets/DM-45331
branch
from
d7e3230
to
4e12f89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The poller for the current objects only looks in the bucket for objects prefixed with the current day so if a movie is generated the day after, it won't be picked up until the daily historical poll has been completed.
This PR adds a mechanism whereby, if no more current data has been taken for the new day, the poller will look for 'per day' data (e.g. movies) to add to the previous day's page without the need for the client to refresh the page.