DM-44386: Test every page endpoint for loading success #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugyballoons
force-pushed
the
tickets/DM-44386
branch
from
20f2829
to
76b6fcc
Compare
ugyballoons
force-pushed
the
tickets/DM-44386
branch
from
76b6fcc
to
a357b5e
Compare
sebastian-aranda
approved these changes
Aug 23, 2024
tests/handlers/external_test.py
Outdated
| all_cams = [f"{summit.name}/{cam.name}" for cam in summit.cameras] | ||
| online_cams = [f"{summit.name}/{cam.name}" for cam in summit.cameras if cam.online] | ||
| camera_historical = [f"{cam}/historical" for cam in online_cams] | ||
| camera_dates = [f"{cam}/date/{day_obs}" for cam in online_cams if cam] |
There was a problem hiding this comment.
Why does only this case use the if cam checking? (when iterating over online_cams).
There was a problem hiding this comment.
Good spot, thanks! It's redundant.
tests/handlers/external_test.py
Outdated
|
|
||
| # TODO: This needs not to be just a success, but a page with a | ||
| # 'nothing for this day' message. | ||
| # See DM-45327 https://rubinobs.atlassian.net/browse/DM-45327 |
There was a problem hiding this comment.
We closed this ticket, so should this part change? at least remove the TODO perhaps? If there is still work to do, please add another ticket 🙏.
ugyballoons
force-pushed
the
tickets/DM-44386
branch
from
adad56e
to
5aaf5ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also test for invalid dates