DM-45007: Memory leak in Prompt Processing service #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
Jul 9, 2024
Doing any string conversions in the template, instead of in the values files, makes for a more user-friendly interface and avoids human error. The use of toString allows compatibility with values that really are strings in the first place.
This flag is useful for working around memory leaks and other aging problems. Since this *is* a workaround, reboots are turned off by default.
The production systems that disable autoscaling are the only ones where a pod is likely to last long enough for memory leaks to be an issue. Even ComCamSim-dev doesn't hit the limit.
kfindeisen
force-pushed
the
tickets/DM-45007
branch
from
1567352
to
366fdb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some Prompt Processing config cleanup and adds worker recycling for LATISS-prod and ComCamSim-prod.