Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-43555: Add phalanx environment install command #3165

Merged
merged 7 commits into from
Apr 9, 2024
Merged

DM-43555: Add phalanx environment install command #3165

merged 7 commits into from
Apr 9, 2024

Commits on Apr 9, 2024

  1. Add phalanx environment install command 

    Port the installer/install.sh script to Python as the new phalanx
environment install command. Add a strongly worded confirmation
message before proceeding, which can be overrriden with a command
line flag for CI testing.

Expand the Helm storage layer and add Argo CD and Kubernetes
storage layers to support the installer. Use kubectl rather than
the Python Kubernetes libraries to manipulate Kubernetes objects,
since it's simpler and more straightforward for the type of actions
the installer needs to take.

Introduce a new way of passing around Vault credentials, and support
authenticating to Vault with an AppRole, at least in the context of
the installer. (The secrets and vault commands still require tokens.)

Remove the old installer and switch GitHub Actions CI over to the
new command.
    @rra
    rra committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    4c99bdf View commit details
    Browse the repository at this point in the history

  2. Document the new Phalanx installer 

    Remove documentation for the old install script and document the
new installation process. Fix an ordering problem in the documentation
for how to set up a new environment by putting assembly of the
configuration for that environment before setting up secrets management.
    @rra
    rra committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    4bb4d10 View commit details
    Browse the repository at this point in the history

  3. Rephrase vault-secrets-operator bootstrapping 

    Be a bit clearer about how the secret for vault-secrets-operator
is created.
    @rra
    rra committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    fd17468 View commit details
    Browse the repository at this point in the history

  4. Improve some docstrings 

    Add better explanations of the GitHub-specific output code and the
command execution layer.
    @rra
    rra committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    fd283a6 View commit details
    Browse the repository at this point in the history

  5. Increase sync timeout in installer 

    Wait for a minute instead of 30 seconds for the sync of each
infrastructure application.
    @rra
    rra committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    a2534d7 View commit details
    Browse the repository at this point in the history

  6. Fix obtaining the current Git branch 

    When running in the merge queue, we do fall back on Git operations
to determine the current branch. Return the branch name, not a
Head object.
    @rra
    rra committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    c820e88 View commit details
    Browse the repository at this point in the history

  7. Further increase installer timeouts 

    We're still getting timeouts in GitHub Actions. Increase the
timeouts for Helm and Argo CD operations even further.
    @rra
    rra committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    eb44ffd View commit details
    Browse the repository at this point in the history