DM-40143: Adopt new notebook execution result with error field #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command is no longer included in tox.ini
Use backtracking resolver and add a update-deps-no-hashes target for development against git-based dependencies.
The execution endpoint provided by jupyterlab utils has changed; if an exeception is triggered by a notebook execution then the notebook will still be returned. Additionally, the exception information is included in an error field. The NotebookResponse model now includes this information in an ipynb_error field that includes: - traceback string - exeception name - exception message
The original @validator is deprecated
The traceback and message end up being the same; so we'll only show the "message" for now. We can re-add the "traceback" later if we find it does contain more information.
jonathansick
force-pushed
the
tickets/DM-40143
branch
from
afaeebb
to
e69d514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notebook execution extension from rsp-jupyter-extensions now returns the notebook even if an execption was raised while executing the notebook. As well, the extension now returns a JSON object with fields:
notebook(the executed ipynb)resources(the resources dictionary)error(structured information about the exception raised, or null)The result of
erroris now made available from theGET /notebooks/:job_idendpoint under the newipynb_errorfield.This PR also adds a tutorial in the user guide on how to use Noteburst's API.