Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cadc libraries / Enable UWS init action / Switch to tomcat image #101

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

stvoutsin
Copy link
Member

@stvoutsin stvoutsin commented Jun 11, 2024

Description

This PR addresses a few tasks / issues:

  • Enable UWS Initialisation / Used for populating an empty UWS database, which will be useful now that we are switching UWS to CloudSQL
  • Fix Capabilities (based on discussions with rra / following cadc / taplint validator)
  • Adds scriv changelog documentation (Don't know if I got that quite right yet?)
  • Tag Authenticator as deprecated. Functionality now part of the upstream cadc-tap code, via the IdentityManager class
  • Switch to using cadc-tomcat base Docker image
  • Bring cadc library versions up-to-date

Related JIRA issues

https://rubinobs.atlassian.net/browse/DM-44607
https://rubinobs.atlassian.net/browse/DM-44746
https://rubinobs.atlassian.net/browse/DM-44524

How was this tested

Tested on dev with custom DockerHub image built from local:

  • sync / async queries (manual)
  • Firefly UI test (manual)
  • taplint validator
  • JUnit tests (gradle)

Compatibility

  • Backwards compatible for clients

Notes

Using this release will require changing the phalanx version currently on main (lsst-sqre/phalanx@6bfd359)
If merged new PR for phalanx will be made with these changes.
Also, capabilities may be revisited upon further validation tests.

@stvoutsin stvoutsin marked this pull request as draft June 11, 2024 21:44
@stvoutsin stvoutsin marked this pull request as ready for review June 11, 2024 23:34
@stvoutsin stvoutsin changed the title Tickets/dm 44607 Update Cadc libraries / Enable UWS init action / Switch to tomcat image Jun 11, 2024
Copy link
Member

@rra rra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct so far as I can tell, and certainly more correct than it was before.

For scriv, we use slightly different categories and a slightly different template than the defaults. You can copy them from the tool.scriv section of https://github.com/lsst/templates/blob/main/project_templates/fastapi_safir_app/example/pyproject.toml and from https://github.com/lsst/templates/blob/main/project_templates/fastapi_safir_app/example/changelog.d/_template.md.jinja

@stvoutsin
Copy link
Member Author

This looks correct so far as I can tell, and certainly more correct than it was before.

For scriv, we use slightly different categories and a slightly different template than the defaults. You can copy them from the tool.scriv section of https://github.com/lsst/templates/blob/main/project_templates/fastapi_safir_app/example/pyproject.toml and from https://github.com/lsst/templates/blob/main/project_templates/fastapi_safir_app/example/changelog.d/_template.md.jinja

Ok thanks for reviewing, I've updated the scriv settings to match the categories & template you use, and do the same for the tap-postgres repo

…pdate Docker container / Fix maxActive setting
@stvoutsin stvoutsin merged commit 913fdb5 into master Jun 13, 2024
2 checks passed
@stvoutsin stvoutsin deleted the tickets/DM-44607 branch June 13, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants