Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed target version for vosi, fixes issue with build #100

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

stvoutsin
Copy link
Member

Description:
PR addresses issue where most recent version on main fails to build.
Build run locally using Gradle version 7.6 produces compilation errors:

/app/src/main/java/org/opencadc/tap/ws/TAPWebService.java:85: error: TAPWebService is not abstract and does not override abstract method getStatus() in AvailabilityPlugin
public class TAPWebService implements AvailabilityPlugin {
       ^
/app/src/main/java/org/opencadc/tap/ws/TAPWebService.java:119: error: getStatus() in TAPWebService cannot implement getStatus() in AvailabilityPlugin
    public Availability getStatus() {
                        ^
  return type Availability is not compatible with AvailabilityStatus
/app/src/main/java/org/opencadc/tap/ws/TAPWebService.java:118: error: method does not override or implement a method from a supertype
    @Override

Likely Cause:
Cause seemed to the version of cadc-vosi library that gets imported is in the range of 1.0 - 1.4, though the change to use Availability in the AvailabilityPlugin interface was introduced in a version 1.4.

Relevant PR:
https://rubinobs.atlassian.net/browse/DM-44561

Fix:
Set the target version to >= 1.4.1

Copy link
Member

@rra rra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need an approval to merge, but for the record, LGTM.

@stvoutsin stvoutsin merged commit 511548e into master Jun 5, 2024
2 checks passed
@stvoutsin stvoutsin deleted the tickets/DM-44561 branch June 5, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants