Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evm functions removed from client #199

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Evm functions removed from client #199

wants to merge 8 commits into from

Conversation

eduardonunesp
Copy link
Contributor

@eduardonunesp eduardonunesp commented Jan 17, 2019 •
edited
Loading

  • Evm functions moved for EvmQueries class, evm functions will be accessed by evm property on Client
  • Added deprecation warnings on Client
  • Updated loom-provider to use evm propery on Client
  • Test that uses evm functions without loom-provider upated

Future breaking change on EVM functions called from Client, now calls made from Client to EVM should be preceded by evm, like client.evm.getEvmBlockByHashAsync

@eduardonunesp eduardonunesp changed the title [WIP] Evm functions removed from client Evm functions removed from client Jan 17, 2019
@eduardonunesp eduardonunesp mentioned this pull request Jan 17, 2019
Open
@eduardonunesp eduardonunesp changed the title Evm functions removed from client [WIP] Evm functions removed from client Sep 11, 2019
@eduardonunesp eduardonunesp changed the title [WIP] Evm functions removed from client Evm functions removed from client Sep 11, 2019
enlight
enlight reviewed Sep 12, 2019
View reviewed changes
Copy link
Contributor

@enlight enlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really see the point of this refactor, we'll probably cull all these EVM functions from the client in one swift move once the /eth endpoint has been sufficiently battle tested.

@eduardonunesp
Copy link
Contributor Author

Yeh, /eth will replace all of this for sure, we still have some fixes to do on /eth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enlight enlight enlight left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eduardonunesp @enlight