Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bad python package exclude #1521

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jeremytchang
Copy link
Collaborator

@jeremytchang jeremytchang commented Oct 16, 2024

The original exclude only included the looker_sdk folder. Afaict based off other examples, we should be using exclude.

Confirmed this fixes #1518 locally.

The original exclude instead only included the `looker_sdk` folder.
Afaict based off other examples, we should be using exclude.
@jeremytchang jeremytchang requested a review from a team as a code owner October 16, 2024 17:12
Copy link
Collaborator

@drstrangelooker drstrangelooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks LGTM To Me

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Python Tests

  9 files  + 1    9 suites  +1   1m 15s ⏱️ +17s
144 tests ± 0  136 ✅  -  3   5 💤 ±0  3 ❌ +3 
676 runs  +24  654 ✅ +20  19 💤 +1  3 ❌ +3 

For more details on these failures, see this check.

Results for commit d02eb62. ± Comparison against base commit 87b0976.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python SDK v24.18.0 can't import looker_sdk
2 participants