Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow duplicate values for URL params #184

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

drstrangelooker
Copy link
Contributor

Local merge of #177

Eino GOURDIN and others added 3 commits March 19, 2024 14:01
Allow duplicate same-named params, so as to support multiple hide_filter.
feat: allow duplicate values for URL params
@drstrangelooker drstrangelooker requested a review from a team as a code owner April 29, 2024 13:47
@drstrangelooker
Copy link
Contributor Author

@bryans99 Can you look at the doc freshness test failure here?

@deepakshukla-bidgely
Copy link

Hi @bryans99 Can you please check this? It's quite urgent.

@deepakshukla-bidgely
Copy link

Hi @bryans99,

Could you please review the updates on this PR at your earliest convenience? This feature is urgently needed for my project, and your prompt attention would be greatly appreciated.

Thank you!

Copy link
Contributor Author

@drstrangelooker drstrangelooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryans99 bryans99 merged commit 836cc25 into master Jul 29, 2024
7 checks passed
@bryans99 bryans99 deleted the duplicate-values branch July 29, 2024 23:35
@bryans99
Copy link
Collaborator

Published @looker/embed-sdk 1.8.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants