ci: change to use GitHub actions

[FrankYang0529]

Which issue(s) this PR fixes:

longhorn/longhorn#8039

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

[FrankYang0529]

Hi @derekbit, may you help to check the error test case? It looks like we didn't have CI for this repository.

[derekbit]

iscsi_test.go:81:
    c.Assert(err, IsNil)
... value *errors.withStack = failed to execute: /usr/bin/nsenter [nsenter iscsiadm --version], output , stderr nsenter: failed to execute iscsiadm: No such file or directory
: exit status 1 ("failed to execute: /usr/bin/nsenter [nsenter iscsiadm --version], output , stderr nsenter: failed to execute iscsiadm: No such file or directory\n: exit status 1")

iSCSI service is not installed.
Check the installation in the doc on different OSes.

[derekbit]

Found found the Dockerfile.dapper relise ubuntu:16.04 base image. @FrankYang0529 Can you help create a ticket for migrating it to BCI image? Thank you.

[FrankYang0529]

iscsi_test.go:81:
    c.Assert(err, IsNil)
... value *errors.withStack = failed to execute: /usr/bin/nsenter [nsenter iscsiadm --version], output , stderr nsenter: failed to execute iscsiadm: No such file or directory
: exit status 1 ("failed to execute: /usr/bin/nsenter [nsenter iscsiadm --version], output , stderr nsenter: failed to execute iscsiadm: No such file or directory\n: exit status 1")

iSCSI service is not installed. Check the installation in the doc on different OSes.

Thank you. It looks like the error message change after I add open-iscsi.

[derekbit]

value *errors.withStack = failed to execute: /usr/bin/nsenter [nsenter iscsiadm -m discovery -t sendtargets -p 172.17.0.2], output , stderr iscsiadm: c

kernel module is missing. Try modprobe iscsi_tcp.

[innobead]

Need to fix the failed PR check.

Running tests
modprobe: FATAL: Module iscsi_tcp not found in directory /lib/modules/6.5.0-1018-azure
Failed to load iscsi_tcp module
time="2024-04-30T06:37:02Z" level=fatal msg="exit status 1"
make: *** [Makefile:11: ci] Error 1

[derekbit]

@FrankYang0529 Is it ready to review?

[FrankYang0529]

@FrankYang0529 Is it ready to review?

This one is like go-spdk-helper and longhorn-spdk-engine. It need system modules like iSCSI daemon. Do you know how to start it in container? The testing error message is:

: exit status 12 ("failed to execute: /usr/bin/nsenter [nsenter iscsiadm -m discovery -t sendtargets -p 172.17.0.2], output , stderr Running in chroot, ignoring command 'start'\niscsiadm: can not connect to iSCSI daemon (111)!\niscsiadm: Could not scan /sys/class/iscsi_transport.\nlibkmod: kmod_module_insert_module: could not find module by name='iscsi_tcp'\niscsiadm: Could not insert module tcp. Kmod error -2\niscsiadm: iSCSI driver tcp is not loaded. Load the module then retry the command.\niscsiadm: Could not perform SendTargets discovery: iSCSI driver not found. Please make sure it is loaded, and retry the operation\n: exit status 12")

[derekbit]

@FrankYang0529 Is it ready to review?

This one is like go-spdk-helper and longhorn-spdk-engine. It need system modules like iSCSI daemon. Do you know how to start it in container? The testing error message is:

: exit status 12 ("failed to execute: /usr/bin/nsenter [nsenter iscsiadm -m discovery -t sendtargets -p 172.17.0.2], output , stderr Running in chroot, ignoring command 'start'\niscsiadm: can not connect to iSCSI daemon (111)!\niscsiadm: Could not scan /sys/class/iscsi_transport.\nlibkmod: kmod_module_insert_module: could not find module by name='iscsi_tcp'\niscsiadm: Could not insert module tcp. Kmod error -2\niscsiadm: iSCSI driver tcp is not loaded. Load the module then retry the command.\niscsiadm: Could not perform SendTargets discovery: iSCSI driver not found. Please make sure it is loaded, and retry the operation\n: exit status 12")

It seems kernel module is not found.
Can you try modprobe iscsi_tcp?

[FrankYang0529]

@FrankYang0529 Is it ready to review?

This one is like go-spdk-helper and longhorn-spdk-engine. It need system modules like iSCSI daemon. Do you know how to start it in container? The testing error message is:

: exit status 12 ("failed to execute: /usr/bin/nsenter [nsenter iscsiadm -m discovery -t sendtargets -p 172.17.0.2], output , stderr Running in chroot, ignoring command 'start'\niscsiadm: can not connect to iSCSI daemon (111)!\niscsiadm: Could not scan /sys/class/iscsi_transport.\nlibkmod: kmod_module_insert_module: could not find module by name='iscsi_tcp'\niscsiadm: Could not insert module tcp. Kmod error -2\niscsiadm: iSCSI driver tcp is not loaded. Load the module then retry the command.\niscsiadm: Could not perform SendTargets discovery: iSCSI driver not found. Please make sure it is loaded, and retry the operation\n: exit status 12")

It seems kernel module is not found. Can you try modprobe iscsi_tcp?

We can't use modprobe command in container. It's like issue in longhorn-spdk-engine and go-spdk-helper.

[derekbit]

@FrankYang0529 Is it ready to review?

This one is like go-spdk-helper and longhorn-spdk-engine. It need system modules like iSCSI daemon. Do you know how to start it in container? The testing error message is:

: exit status 12 ("failed to execute: /usr/bin/nsenter [nsenter iscsiadm -m discovery -t sendtargets -p 172.17.0.2], output , stderr Running in chroot, ignoring command 'start'\niscsiadm: can not connect to iSCSI daemon (111)!\niscsiadm: Could not scan /sys/class/iscsi_transport.\nlibkmod: kmod_module_insert_module: could not find module by name='iscsi_tcp'\niscsiadm: Could not insert module tcp. Kmod error -2\niscsiadm: iSCSI driver tcp is not loaded. Load the module then retry the command.\niscsiadm: Could not perform SendTargets discovery: iSCSI driver not found. Please make sure it is loaded, and retry the operation\n: exit status 12")

It seems kernel module is not found. Can you try modprobe iscsi_tcp?

We can't use modprobe command in container. It's like issue in longhorn-spdk-engine and go-spdk-helper.

You can modprobe it in the hostname space instead.

[derekbit]

Hi @derekbit, may you help to check the error test case? It looks like we didn't have CI for this repository.

You are right. I just realized we never run CI here.

[derekbit]

@FrankYang0529 @innobead
We never ran the CI test.
I tried to fix the error but with no luck for now

 exit status 20 ("failed to execute: /usr/bin/nsenter [nsenter iscsiadm -m discovery -t sendtargets -p 172.17.0.3], 
output , stderr System has not been booted with systemd as init system (PID 1). Can't operate.\nFailed to connect to bus:
 Host is down\niscsiadm: can not connect to iSCSI daemon (111)!\nSystem has not been booted with systemd as init system (PID 1). Can't operate.\n
 Failed to connect to bus: Host is down\niscsiadm: can not connect to iSCSI daemon (111)!\niscsiadm: Cannot perform discovery. Initiatorname required.\n
 iscsiadm: Could not perform SendTargets discovery: could not connect to iscsid\n: exit status 20")

I think we can disable CI test as before and fix it later. WDYT?

[FrankYang0529]

I think we can disable CI test as before and fix it later. WDYT?

Agree. The go-iscsi-helper works well. We just need to find a way to test it in the future. Thank you.