fix: Only get PartialObjectMetadata in mappings GC #2233
Merged
+274
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.
|
FabianKramm
approved these changes
Oct 16, 2024
ThomasK33
force-pushed
the
thomaskosiewski/etcd-client-fixes
branch
8 times, most recently
from
bc66084
to
7ffe2fa
Compare
ThomasK33
changed the title
Signed-off-by: Thomas Kosiewski <[email protected]>
ThomasK33
force-pushed
the
thomaskosiewski/etcd-client-fixes
branch
from
7ffe2fa
to
a8ae8c5
Compare
|
Some stuff in here we'll need to address in future (ie: https://github.com/loft-sh/vcluster/pull/2233/files#diff-201bae62fde93bdc51a8720dd2f82e08a531df9a8d332a95090d14cf1de1091aR91), but merging now to cut a beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vCluster mappings garbage collection would hang and cause the entire syncer process to deadlock.
What else do we need to know?