fix: bundle should not start a new list entry #1212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
/kind documentation
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>
if possible)resolves #1211
This fixes an issue where the
bundle
attribute was starting a new list entry and cutting off any providedchart
information which is needed for extracting the tar file into a specific filename.Also updated the documentation example and values.yaml files to provide more information on the
init
helm chart entries.Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster could not apply more than one bundled helm chart.
What else do we need to know?
The
init
code assumes that thechart.name
,chart.repo
andchart.version
are populated for bothbundle
andrepo
charts. Therepo
is not technically needed for bundled charts and the filename can be generated without it. Requiring the name and version for a bundled chart may seem a little odd, but it's the way the tar file name is determined, so unless that code gets refactored thechart.name
andchart.version
should be specified even for bundled charts.