Merge pull request #1413 from facchettos/k0s-dual-stack

disabled dualstack for k0s

cmd/vclusterctl/cmd/create.go

@@ -524,6 +524,10 @@ func (cmd *CreateCmd) prepare(ctx context.Context, vClusterName string) error {
 		if warning != "" {
 			cmd.log.Debug(warning)
 		}
+		if cmd.Distro == "k0s" {
+			// there is currently a problem with dualstack when we use k0s
+			cidr = strings.Split(cidr, ",")[0]
+		}
 		cmd.CIDR = cidr
 	}
 

docs/pages/deploying-vclusters/supported-distros.mdx

@@ -41,6 +41,8 @@ kubectl get ns
 
 Behind the scenes a different helm chart will be deployed (`vcluster-k0s`), that holds specific configuration to support k0s. Check the [github repository](https://github.com/loft-sh/vcluster/tree/main/charts/k0s) for all available chart options.
 
+Please note that dual stack networking is not supported with k0s, you will be able to deploy it on a dual stack host cluster, but it will not have all the dual stack features.
+
 ## Vanilla k8s
 
 When choosing this option, vCluster will deploy a separate etcd cluster, kubernetes controller manager and api server alongside the vCluster hypervisor.

pkg/util/servicecidr/servicecidr.go

@@ -116,6 +116,8 @@ func EnsureServiceCIDRInK0sSecret(
 	if warning != "" {
 		klog.Info(warning)
 	}
+	// only return the first cidr, because k0s don't accept coma separated ones
+	serviceCIDR = strings.Split(serviceCIDR, ",")[0]
 
 	// apply changes
 	originalObject := secret.DeepCopy()