Steps with neg sigma #970
Open
Steps with neg sigma #970
+77
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #970 +/- ##
==========================================
+ Coverage 93.13% 93.24% +0.10%
==========================================
Files 10 10
Lines 3787 3789 +2
==========================================
+ Hits 3527 3533 +6
+ Misses 260 256 -4 ☔ View full report in Codecov by Sentry. |
reneeotten
reviewed
Oct 8, 2024
There was a problem hiding this comment.
thanks @newville a few minor typos perhaps but other than that looks good to me. Perhaps just squash the commits?
| Starts at 0.0, ends at `amplitude`, with half-max at `center`, and | ||
| rising with `form`: | ||
| Starts at 0.0, ends at `sign(sigma)*amplitude`, has a half-max at | ||
| `center`, rsing or falling with `form`: |
| :math:`A` rising to :math:`A/2` at :math:`\mu`, with :math:`\sigma` | ||
| setting the characteristic width. The functional forms are defined as: | ||
| :math:`\tt{sign}(\sigma)A` rising or falling to :math:`A/2` at :math:`\mu`, | ||
| with :math:`\sigma` setting the characteristic width and the sign up the step. |
There was a problem hiding this comment.
"sign up" is that what you meant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows the
steplineshape andStepModelto have values ofsigma<0to signify a step down (from 1 to 0).See discussion at: https://groups.google.com/g/lmfit-py/c/aBBzQG0uDK4
Type of Changes
Tested on
Python: 3.12.5 | packaged by conda-forge | (main, Aug 8 2024, 18:31:54) [Clang 16.0.6 ]
lmfit: 1.3.2.post9+g776e14d7.d20241007, scipy: 1.14.0, numpy: 1.26.4, asteval: 1.0.5, uncertainties: 3.2.2.post7+gce16269
Verification
Have you