lklfuse: migrate to libfuse3 #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a typo while there. Signed-off-by: David Disseldorp <[email protected]>
The utimens array layout is { atime, mtime } but in copying the values
from timespec to lkl_timespec, fuse source array offset 0 (atime) is
used for both lkl_timespec atime and mtime values.
Signed-off-by: David Disseldorp <[email protected]>
This ensures that file times aren't stuck around Epoch. Signed-off-by: David Disseldorp <[email protected]>
Update to the new libfuse3 API, which has a number of attractive features for lkl: - an lseek() hook with SEEK_DATA / SEEK_HOLE - copy_file_range() - RENAME_NOREPLACE and RENAME_EXCHANGE. Aside from passing through the rename flags, the remaining features still need to be added to lklfuse. This commit attempts to be a direct switch over to the new API. The last upstream release of libfuse2 was in 2019 (2.9.9), so it makes sense to upgrade regardless of the new functionality. Signed-off-by: David Disseldorp <[email protected]>
|
force pushed update (v2):
|
|
LGTM, thanks David! The test error looks like an infra / test flakiness issue, I've restarted it just to make sure. checkpatch fails for one of the patches in the series which was fixed later, no need to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the process of adding lklfuse support to xfstests. Some tests exercise lseek(SEEK_HOLE/SEEK_DATA) behaviour, which isn't supported prior to libfuse3. This upgrade puts us in a better position to support these seek types as well as
copy_file_range().A couple of other minor changes are also included.