Misc cleanups and minor fixes #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utimensat() needs a valid directory fd if the pathname is relative. Use AT_FDCWD to ensure that relative paths are correctly handled. Signed-off-by: David Disseldorp <[email protected]>
Some distributions require libraries in e.g. /usr/lib64, so add support for overriding common install paths via LIBDIR, BINDIR and INCDIR. Signed-off-by: David Disseldorp <[email protected]>
The current handler unintentionally returns ARGP_ERROR_UNKNOWN for the non-error case (via case fallthrough). As per argp.h, this error return gets ignored, so doesn't cause any problems: What to return for unrecognized keys. For special ARGP_KEY_ keys, such returns will simply be ignored. Still worth fixing for the compiler warnings. Signed-off-by: David Disseldorp <[email protected]>
As per commit bd71558 ("arch: um: Mark the stack non-executable to fix a binutils warning"): Since binutils 2.39, ld will print a warning if any stack section is executable, which is the default for stack sections on files without a .note.GNU-stack section. Signed-off-by: David Disseldorp <[email protected]>
Check for disk (image) and fstype parameters, to avoid segfaulting immediately. Failure to open the image or invalid fstype will still result in segfault. Signed-off-by: David Disseldorp <[email protected]>
|
LGTM. For the qemu test, it often fails randomly (I haven't investigated so far but I should) so, it should be unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ease of review, I decided to split these out from the v6.4 merge PR.