Rb/foundry upgradeability refactoring #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…balTotalSupplyFix, fixed MinterGlobalTotalSupplyFix upgrade function
kautukkundan
suggested changes
May 24, 2022
0xcadams
reviewed
May 25, 2022
…o validate 'Bond' event
RiccardoBiosas
force-pushed
the
rb/foundry-upgradeability-refactoring
branch
from
96c9fc5
to
e2152f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
The current Foundry tests include a lot of repeating logic and code duplication, the PR addresses the issue by moving all the shared interfaces under a single directory and by creating a shared base test contract to encapsulate the governor logic used by other contracts/tests
Specific updates (required)
Refactored all the Foundry tests
How did you test each of these updates (required)
Run the the entire hardhat test suite (
yarn test) and the foundry testsDoes this pull request close any open issues?
Refactor Foundry tests
Checklist:
yarn testpass