Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate litestar.contrib.sqlalchemy #3755

Merged
merged 19 commits into from
Sep 23, 2024

Conversation

cofin
Copy link
Member

@cofin cofin commented Sep 22, 2024

Description

This PR deprecates the litestar.contrib.sqlalchemy module in favor of litestar.plugins.sqlalchemy

Closes

@cofin cofin requested review from a team as code owners September 22, 2024 00:00
@github-actions github-actions bot added area/dependencies This PR involves changes to the dependencies size: medium type/feat labels Sep 22, 2024
@github-actions github-actions bot added the area/docs This PR involves changes to the documentation label Sep 22, 2024
@github-actions github-actions bot added area/plugins This PR involves changes to the plugins size: large and removed size: medium labels Sep 22, 2024
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 99.05660% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.35%. Comparing base (8e875c1) to head (97ee362).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
litestar/contrib/sqlalchemy/__init__.py 93.75% 0 Missing and 1 partial ⚠️
litestar/contrib/sqlalchemy/repository/__init__.py 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3755    +/-   ##
========================================
  Coverage   98.35%   98.35%            
========================================
  Files         331      332     +1     
  Lines       15287    15460   +173     
  Branches     2447     2460    +13     
========================================
+ Hits        15035    15206   +171     
  Misses        112      112            
- Partials      140      142     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3755

@cofin cofin merged commit b187749 into litestar-org:main Sep 23, 2024
25 checks passed
@cofin cofin deleted the deprecation-sqlalchemy branch September 23, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies This PR involves changes to the dependencies area/docs This PR involves changes to the documentation area/plugins This PR involves changes to the plugins pr/internal size: large type/feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants