-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DTO): Enable codegen backend by default #3215
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3215 +/- ##
===========================================
+ Coverage 98.23% 98.27% +0.03%
===========================================
Files 312 322 +10
Lines 14121 14676 +555
Branches 2430 2330 -100
===========================================
+ Hits 13872 14423 +551
- Misses 107 112 +5
+ Partials 142 141 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wish we had some good metrics on usage here to see how many people are trying this out.
I agree with this approach. I've been using it for some time with no issues. |
While we have two users (maintainers 🙂) using and approving this feature, I have to say I am kinda of "weary" (if this comes off as a strong word, my apologies) of this approach. I feel we should "promote" this experimental feature more. What I mean is, probably have a lot of links (backlinks?) that lead to https://docs.litestar.dev/latest/usage/dto/0-basic-use.html#enabling-the-backend. Or even have a poll (or just a normal question) in the discord to get these two data points.
My reason for this comment is, I (not talking about other maintainers / members 🙂 ) do not think many are aware of this. How did I arrive at that conclusion? I have not seen a significant number of users ask about this in discord. To me that could mean either of the following
|
I see your point @Alc-Alc but the backend is supposed to be backward compatible - so as long as we do this with the guarantee that any change in behavior should be considered a bug then this shouldn't be different to rolling out any other backward compatible optimization. Also, this PR doesn't remove the current backend, so there is a pretty easy escape hatch users can apply while we address any issues. |
Definitely need to adjust the docs though, thanks for the reminder @Alc-Alc |
a40557d
to
0617e10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was here
0617e10
to
f7bccdb
Compare
Quality Gate passedIssues Measures |
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3215 |
* Enable DTO codegen backend by default * Update docs
* Enable DTO codegen backend by default * Update docs
* Enable DTO codegen backend by default * Update docs
* Enable DTO codegen backend by default * Update docs
* Enable DTO codegen backend by default * Update docs
* Enable DTO codegen backend by default * Update docs
* Enable DTO codegen backend by default * Update docs
* Enable DTO codegen backend by default * Update docs
Enable the codegen backend for DTOs introduced in #2388 by default. We have initially hidden this behind a feature flag to see how it works out in production. It's been smooth sailing for about 6 months now so I think we can enable it by default. This gives us enough time to decide if we want to remove the regular backend entirely in 3.0.