feat(DTO): deterministic transfer model names #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janek Nouvertné <[email protected]>
JacobCoffee
approved these changes
Sep 30, 2023
Alc-Alc
approved these changes
Sep 30, 2023
Signed-off-by: Janek Nouvertné <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently ensure uniqueness of the generated transfer model names by appending a random string to a base name. This makes debugging and testing harder in cases where you want to reference / compare the models between runs, since the names differ on every run.
This PR introduces a helper function that generates a unique name by simply appending an increasing integer to the base name, ensuring that, given nothing else changed, transfer models will have the same names.