Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Piccolo ORM DTO #1896

Merged
merged 9 commits into from
Jul 1, 2023
Merged

Conversation

Goldziher
Copy link
Contributor

@Goldziher Goldziher commented Jul 1, 2023

This PR adds a piccolo ORM DTO.

I also revert some 'fixes' added by sourcery in a previous PR in this scope.

@Goldziher Goldziher linked an issue Jul 1, 2023 that may be closed by this pull request
@Goldziher Goldziher changed the title feat: initial piccolo DTO Add Piccolo ORM DTO Jul 1, 2023
'Refactored by Sourcery'

Co-authored-by: Sourcery AI <>
@Goldziher Goldziher marked this pull request as ready for review July 1, 2023 15:31
@Goldziher Goldziher requested a review from a team as a code owner July 1, 2023 15:31
@Goldziher Goldziher force-pushed the 1533-dto-factory-piccolo-implementation branch 2 times, most recently from 7064631 to c0c2509 Compare July 1, 2023 18:39
@Goldziher Goldziher force-pushed the 1533-dto-factory-piccolo-implementation branch from c0c2509 to 56fe34c Compare July 1, 2023 18:49
Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good to me other than the unrelated test failure.

@Goldziher Goldziher merged commit d62df1f into main Jul 1, 2023
10 checks passed
@Goldziher Goldziher deleted the 1533-dto-factory-piccolo-implementation branch July 1, 2023 19:14
@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

92.9% 92.9% Coverage
0.5% 0.5% Duplication

@github-actions
Copy link

github-actions bot commented Jul 1, 2023

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/1896

provinzkraut added a commit that referenced this pull request Jul 15, 2023
#1896 introduced some changes that would cause some individual channels tests to run for 30+ seconds. This has been reverted and the underlying cause addressed by giving the flaky tests more attempts to re-run.
provinzkraut added a commit that referenced this pull request Jul 15, 2023
#1896 introduced some changes that would cause some individual channels tests to run for 30+ seconds. This has been reverted and the underlying cause addressed by giving the flaky tests more attempts to re-run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DTO Factory: piccolo implementation
2 participants