Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details to the TypeScript docs #1346

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Conversation

justinfagnani
Copy link
Contributor

We hadn't mentioned what's required from a TypeScript config in this section yet.

Copy link

github-actions bot commented Jul 2, 2024

A live preview of this PR will be available at the URL(s) below.
The latest URL will be appended to this comment on each push.
Each build takes ~5-10 minutes, and will 404 until finished.

https://pr1346-eec82d7---lit-dev-5ftespv5na-uc.a.run.app/

@justinfagnani justinfagnani changed the base branch from main to typescript-note July 2, 2024 00:46
@justinfagnani justinfagnani changed the title Typescript info Add more details to the TypeScript docs Jul 2, 2024
Copy link
Contributor

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from typescript-note to main July 2, 2024 01:24
@justinfagnani justinfagnani merged commit 24f0803 into main Jul 2, 2024
15 checks passed
@justinfagnani justinfagnani deleted the typescript-info branch July 2, 2024 01:26
@@ -202,12 +202,23 @@ For full installation and usage instructions, see the [Web Dev Server documentat

## TypeScript { #typescript }

TypeScript extends the Javascript language by adding support for types. Types are useful for catching errors early and making code more readable and understandable.
Lit support developing components in TypeScript, including full type declarations for the Lit APIs, standard and experimental decorators, and community tools for template type-checking and linting.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supports*

also I think differentiating between decorators isn’t totally relevant here esp since we tackle that later. Maybe focus a bit more on “it also supports TS” might help be a bit more concise here

TypeScript extends the Javascript language by adding support for types. Types are useful for catching errors early and making code more readable and understandable.
Lit support developing components in TypeScript, including full type declarations for the Lit APIs, standard and experimental decorators, and community tools for template type-checking and linting.

Because Lit is just a library, and doesn't require a compiler or use non-standard langauge syntax, there are no specific TypeScript tools that are required. Lit works with the official TypeScript compiler, `tsc`, with TypeScript wrappers such as those for Rollup, Vite, or Webpack, and alternate compilers like `esbuild`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify to reader what you’re implying by “just a library”

@e111077
Copy link
Contributor

e111077 commented Jul 2, 2024

Oops it’s merged

@justinfagnani
Copy link
Contributor Author

Oops it’s merged

I can make those changes though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants