Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocation encoding tests #24

Merged
merged 9 commits into from
Oct 14, 2024

Conversation

GalloDaSballo
Copy link
Collaborator

@GalloDaSballo GalloDaSballo commented Oct 14, 2024

  • Test Encoding and Decoding
  • Verify that Encoding and Decoding are equivalent

The PR adds

    /// We expect this test to fail as the encoding is ambigous past u120
    function testFail_encoding_not_equal_reproducer() public {
        _receive_undo_compare(18371677541005923091065047412368542483005086202);
    }

Which shows that ambigous encoding is possible past u120

We should never have values of that size, however we would do best to enforce this by adding explicit checks

@GalloDaSballo GalloDaSballo merged commit e84c00d into dev-governance-refactor Oct 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants