Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev governance refactor #16

Merged
merged 104 commits into from
Oct 16, 2024
Merged

Dev governance refactor #16

merged 104 commits into from
Oct 16, 2024

Commits on Oct 4, 2024

  1. test for vote amount

    @ColinPlatt
    ColinPlatt committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    958749f View commit details
    Browse the repository at this point in the history

  2. Restrict deltas to int96 and assert <= 2**88

    @jltqy
    jltqy committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f66f972 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. fix: compilation - safeTransfer

    @GalloDaSballo
    GalloDaSballo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f1f741e View commit details
    Browse the repository at this point in the history

  2. feat: introduce lastEpochClaim

    @GalloDaSballo
    GalloDaSballo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d56007f View commit details
    Browse the repository at this point in the history

  3. feat: invariant - can only claim or unregister per epoch

    @GalloDaSballo
    GalloDaSballo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    66f081c View commit details
    Browse the repository at this point in the history

  4. fix: test that is broken

    @GalloDaSballo
    GalloDaSballo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    bd34a83 View commit details
    Browse the repository at this point in the history

  5. feat: getInitiativeState

    @GalloDaSballo
    GalloDaSballo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f63a541 View commit details
    Browse the repository at this point in the history

  6. feat: initial fixes around maintaining storage for disabled proposals

    @GalloDaSballo
    GalloDaSballo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a06b94b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into fix/voteCheck

    @GalloDaSballo
    GalloDaSballo authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1be0fb6 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. feat: test_crit_accounting_mismatchand `test_canAlwaysRemoveAllocat… 

    …ion`
    @GalloDaSballo
    GalloDaSballo committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    84fc1e8 View commit details
    Browse the repository at this point in the history

  2. feat: use constant for disabled initiatives

    @GalloDaSballo
    GalloDaSballo committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    dcc3dd0 View commit details
    Browse the repository at this point in the history

  3. chore: cleanup + isolate overflow checks

    @GalloDaSballo
    GalloDaSballo committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    efab2c6 View commit details
    Browse the repository at this point in the history

  4. Restrict deltas to int88

    @jltqy
    jltqy committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e9d117d View commit details
    Browse the repository at this point in the history

  5. feat: FSM is enforced

    @GalloDaSballo
    GalloDaSballo committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a816b67 View commit details
    Browse the repository at this point in the history

  6. chore: remove logs

    @GalloDaSballo
    GalloDaSballo committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    2c52bc3 View commit details
    Browse the repository at this point in the history

  7. feat: return 0 on duplicate claim

    @GalloDaSballo
    GalloDaSballo committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1fee011 View commit details
    Browse the repository at this point in the history

  8. chore: re-order functions

    @GalloDaSballo
    GalloDaSballo committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    838b48c View commit details
    Browse the repository at this point in the history

  9. feat: enum initiative status and improvement to getInitiativeState

    @GalloDaSballo
    GalloDaSballo committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7f66112 View commit details
    Browse the repository at this point in the history

  10. feat: snapshot asserts

    @GalloDaSballo
    GalloDaSballo committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    9e8fd9e View commit details
    Browse the repository at this point in the history

  11. chore: future notes

    @GalloDaSballo
    GalloDaSballo committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e4ccbc0 View commit details
    Browse the repository at this point in the history

  12. feat: counted is gone

    @GalloDaSballo
    GalloDaSballo committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    480c077 View commit details
    Browse the repository at this point in the history

  13. feat: counted is gone

    @GalloDaSballo
    GalloDaSballo committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ac4d1eb View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. feat: introduce vetos as part of snapshot storage

    @GalloDaSballo
    GalloDaSballo committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    9c9f77c View commit details
    Browse the repository at this point in the history

  2. feat: use vetos from snapshot to determine FSM

    @GalloDaSballo
    GalloDaSballo committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    10e3659 View commit details
    Browse the repository at this point in the history

  3. chore: remove unused variable

    @GalloDaSballo
    GalloDaSballo committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    bbc9dc8 View commit details
    Browse the repository at this point in the history

  4. feat: use getInitiativeState for unregisterInitiative

    @GalloDaSballo
    GalloDaSballo committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    27b33db View commit details
    Browse the repository at this point in the history

  5. chore: comments

    @GalloDaSballo
    GalloDaSballo committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    0584ac0 View commit details
    Browse the repository at this point in the history

  6. fix: vetos, lastCountedEpoch and votes FSM follow the spec

    @GalloDaSballo
    GalloDaSballo committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    c1945bf View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Merge branch 'dev-governance-refactor' into fix/voteCheck

    @GalloDaSballo
    GalloDaSballo committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    eb2e1ec View commit details
    Browse the repository at this point in the history

  2. fix: compilation

    @GalloDaSballo
    GalloDaSballo committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    3adf6dc View commit details
    Browse the repository at this point in the history

  3. feat: broken | math tests

    @GalloDaSballo
    GalloDaSballo committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    77fe12b View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. feat: ref vs lib tests

    @GalloDaSballo
    GalloDaSballo committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a4af757 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into dev-governance-refactor

    @GalloDaSballo
    GalloDaSballo committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    78a4e55 View commit details
    Browse the repository at this point in the history

  3. fix: compilation

    @GalloDaSballo
    GalloDaSballo committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    03c5315 View commit details
    Browse the repository at this point in the history

  4. feat: fuzz tests for encoding + decoding allocation

    @nican0r
    nican0r committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a932aa0 View commit details
    Browse the repository at this point in the history

  5. test: unit test for reproducing issue with encoding

    @nican0r
    nican0r committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    65f466b View commit details
    Browse the repository at this point in the history

  6. fix: encoded value passed in for decoding

    @nican0r
    nican0r committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    9e10b09 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'dev-governance-refactor' into allocation-encoding-tests

    @GalloDaSballo
    GalloDaSballo committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d5b9a21 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'dev' into allocation-encoding-tests

    @GalloDaSballo
    GalloDaSballo committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f5d30e8 View commit details
    Browse the repository at this point in the history

  9. fix: random use of solmate

    @GalloDaSballo
    GalloDaSballo committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    629799f View commit details
    Browse the repository at this point in the history

  10. test: rational flow for allocating/claiming bribe

    @nican0r
    nican0r committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e662cb7 View commit details
    Browse the repository at this point in the history

  11. feat: encode / deocde

    @GalloDaSballo
    GalloDaSballo committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f4ca88f View commit details
    Browse the repository at this point in the history

  12. feat: testFail

    @GalloDaSballo
    GalloDaSballo committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    4bb1a58 View commit details
    Browse the repository at this point in the history

  13. Merge pull request #24 from liquity/allocation-encoding-tests 

    Allocation encoding tests
    @GalloDaSballo
    GalloDaSballo authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e84c00d View commit details
    Browse the repository at this point in the history

  14. fix: bribe CEI

    @GalloDaSballo
    GalloDaSballo committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    3a6c038 View commit details
    Browse the repository at this point in the history

  15. fix: cannot claim in the future

    @GalloDaSballo
    GalloDaSballo committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    af5132f View commit details
    Browse the repository at this point in the history

  16. feat: rational flow

    @GalloDaSballo
    GalloDaSballo committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f118d1f View commit details
    Browse the repository at this point in the history

  17. fix: use lib for encoding / decoding

    @GalloDaSballo
    GalloDaSballo committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    12f94ed View commit details
    Browse the repository at this point in the history

  18. chore: adding governance scaffolding

    @nican0r
    nican0r committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    79ab942 View commit details
    Browse the repository at this point in the history

  19. feat: property_GV01

    @nican0r
    nican0r committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d94b2cd View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. feat: adding properties and scaffolding from bribe-initiative-invar-t… 

    …ester
    @nican0r
    nican0r committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2e38b40 View commit details
    Browse the repository at this point in the history

  2. chore: uncommenting properties

    @nican0r
    nican0r committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    eae43cd View commit details
    Browse the repository at this point in the history

  3. chore: updating properties table

    @nican0r
    nican0r committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0d2e524 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' into dev-governance-refactor

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0b1ab3a View commit details
    Browse the repository at this point in the history

  5. fix: add sanity checks to thresholds

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ceb0f7e View commit details
    Browse the repository at this point in the history

  6. feat: move logic to allow removing lastCountedEpoch

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    8b3670e View commit details
    Browse the repository at this point in the history

  7. feat: remove usage of lastCountedEpoch

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9109d98 View commit details
    Browse the repository at this point in the history

  8. feat: for packing

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    089b968 View commit details
    Browse the repository at this point in the history

  9. feat: view variants of snapshot functions

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    b692f5b View commit details
    Browse the repository at this point in the history

  10. chore: cleanup

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    8e60ecb View commit details
    Browse the repository at this point in the history

  11. chore: more cleanuop

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3a7fd77 View commit details
    Browse the repository at this point in the history

  12. feat: stateless checks use memory variables

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ab20d48 View commit details
    Browse the repository at this point in the history

  13. fix: 5.3

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d77fa12 View commit details
    Browse the repository at this point in the history

  14. fix: remove unnecessary threshold

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e39a3fd View commit details
    Browse the repository at this point in the history

  15. Merge pull request #34 from liquity/feat-dev-stateless-checks 

    feat: stateless checks use memory variables
    @GalloDaSballo
    GalloDaSballo authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f964608 View commit details
    Browse the repository at this point in the history

  16. Merge pull request #25 from liquity/bribe-claiming-unit-test 

    EXP - Rational Flow for Bribes and Claims
    @GalloDaSballo
    GalloDaSballo authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d4a20e1 View commit details
    Browse the repository at this point in the history

  17. Merge remote-tracking branch 'origin/gov-invar-tester-after-refactor'… 

    … into dev-governance-refactor
    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d4c2058 View commit details
    Browse the repository at this point in the history

  18. fix: deps

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0b72301 View commit details
    Browse the repository at this point in the history

  19. fix: medusa and signature

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d60e671 View commit details
    Browse the repository at this point in the history

  20. fix: cryticToFoundry and overflow

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6c8de58 View commit details
    Browse the repository at this point in the history

  21. fix: property

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    cd7fba3 View commit details
    Browse the repository at this point in the history

  22. fix: introduce more states to track initiative and fix invariant test

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    dfefc27 View commit details
    Browse the repository at this point in the history

  23. chore: gas + docs

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c4da233 View commit details
    Browse the repository at this point in the history

  24. feat: view vs non view properties

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3d192fa View commit details
    Browse the repository at this point in the history

  25. feat: mostly using FSM, can simplify a bit

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    aed7a96 View commit details
    Browse the repository at this point in the history

  26. feat: commiting to using FSM

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c312fcb View commit details
    Browse the repository at this point in the history

  27. feat: unregisterInitiative FSM equivalence

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    02bf481 View commit details
    Browse the repository at this point in the history

  28. chore: comment

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    121bede View commit details
    Browse the repository at this point in the history

  29. chore: comment

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    5d34676 View commit details
    Browse the repository at this point in the history

  30. feat: simplify claim logic

    @GalloDaSballo
    GalloDaSballo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e80a9ce View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. feat: pretty close to done

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    5f863c3 View commit details
    Browse the repository at this point in the history

  2. feat: cache data for unregisterInitiative

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    cf0f98c View commit details
    Browse the repository at this point in the history

  3. gas: claimForInitiative

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3660391 View commit details
    Browse the repository at this point in the history

  4. fix: remove extra SSTORE

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    16bf1d3 View commit details
    Browse the repository at this point in the history

  5. feat: FSM + Crit notice

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6309c90 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'exp-external-functions-fsm' into dev-governance-refactor

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    ad3d9f8 View commit details
    Browse the repository at this point in the history

  7. gas: remove extra 0 check

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    83657b5 View commit details
    Browse the repository at this point in the history

  8. chore: cleanup

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6b15ed6 View commit details
    Browse the repository at this point in the history

  9. fix: Critical accounting bug

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b45e6a6 View commit details
    Browse the repository at this point in the history

  10. chore: future

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0ae541f View commit details
    Browse the repository at this point in the history

  11. feat: broken key test

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3927a88 View commit details
    Browse the repository at this point in the history

  12. chore: cleanup

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    56b162d View commit details
    Browse the repository at this point in the history

  13. chore: fixes to properties

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    7d375b1 View commit details
    Browse the repository at this point in the history

  14. chore: sample broken pro

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    568f189 View commit details
    Browse the repository at this point in the history

  15. feat: view acounting properties

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    506bf03 View commit details
    Browse the repository at this point in the history

  16. fix: dorky bug

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    60f12ae View commit details
    Browse the repository at this point in the history

  17. feat: broken property

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    c81f05d View commit details
    Browse the repository at this point in the history

  18. feat: trophies

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    1541192 View commit details
    Browse the repository at this point in the history

  19. chore: cleanuop

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    85eecdd View commit details
    Browse the repository at this point in the history

  20. feat: e2e test + make invariant tests more reliable

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4581c3e View commit details
    Browse the repository at this point in the history

  21. chore: further simplify trophy

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b6fc28a View commit details
    Browse the repository at this point in the history

  22. feat: document the vote vs veto bug

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e4ef357 View commit details
    Browse the repository at this point in the history

  23. feat: e2e test for unregistering

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    62ed071 View commit details
    Browse the repository at this point in the history

  24. chore: improved README

    @GalloDaSballo
    GalloDaSballo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e26ab76 View commit details
    Browse the repository at this point in the history