Make clutter_offscreen_effect_get_target available to Cjs #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to enable all effects in the "Cinnamon Burn My Windows" extension it's required that the clutter OffscreenEffect.get_target() API is available to Cjs. I believe that the "(skip)" comment text is a GObject-Introspection annotations that prevents the API from being exposed as a API call in Cjs. The current GNOME equivalent is OffscreenEffect.get_pipeline() which is available to Gjs. https://github.com/GNOME/mutter/blob/625965d956a8818b77eadbdf0ae6e5edbf60b029/clutter/clutter/clutter-offscreen-effect.c#L666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enable all effects in the "Cinnamon Burn My Windows" extension it's required that the clutter OffscreenEffect.get_target() API is available to Cjs. I believe that the "(skip)" comment text is a GObject-Introspection annotations that prevents the API from being exposed as a API call in Cjs. The current GNOME equivalent is OffscreenEffect.get_pipeline() which is available to Gjs. https://github.com/GNOME/mutter/blob/625965d956a8818b77eadbdf0ae6e5edbf60b029/clutter/clutter/clutter-offscreen-effect.c#L666