Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 添加检查是否支持色温的接口 #257

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

fly602
Copy link
Contributor

@fly602 fly602 commented Jun 14, 2024

dock插件迁移需要该接口

dock插件迁移需要该接口
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • setPropColorTemperatureEnabledsetPropSupportColorTemperature函数中,应该检查value是否为有效的布尔值,以避免潜在的类型错误。
  • unsupportGammaDrmList数组中的显卡型号(如"Loongson")应该转换为小写,以避免潜在的比较错误。
  • detectDrmSupportGamma函数中的pciInfos变量应该在循环外部声明,以避免每次迭代时都创建新的切片。
  • getLspci函数中,如果err不为nil,应该返回错误而不是空字符串。
  • SupportSetColorTemperature函数中的inVM参数应该在函数签名中声明,以提高代码的可读性和可维护性。
  • isInVM函数中,cmd.Wait()的错误处理应该包括检查返回的退出码,以确保命令执行成功。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fly602 fly602 requested a review from zsien June 14, 2024 07:35
@fly602
Copy link
Contributor Author

fly602 commented Jun 14, 2024

/merge

@deepin-bot deepin-bot bot merged commit d71a900 into linuxdeepin:master Jun 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants