Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/qt5platform-plugins #44

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#252

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 21, 2024

TAG Bot

New tag: 6.0.19
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #45

Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#252
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DNoTitlebarWindowHelper::DNoTitlebarWindowHelper构造函数中,g_pressPoint.remove(this);可能会导致未处理的初始化问题,如果this已经在g_pressPoint中存在,则调用remove会失败。
  • DNoTitlebarWindowHelper::windowEvent函数中,g_pressPoint[this]的赋值操作应该在if语句块之外,以避免潜在的未初始化问题。
  • QPointF delta = me->globalPos() - g_pressPoint[this];计算了鼠标移动距离,但没有考虑到鼠标移动的累积效应,可能会导致在较短距离下误判移动事件。
  • if (delta.manhattanLength() < QGuiApplication::styleHints()->startDragDistance())中的QGuiApplication::styleHints()->startDragDistance()应该使用QApplication::startDragDistance(),因为QGuiApplication在Qt 6中已经被移除。
  • self->isEnableSystemMove(winId)函数调用可能需要检查是否为有效的窗口ID,以确保安全性。

是否建议立即修改:

@18202781743 18202781743 merged commit d96ed45 into master Aug 27, 2024
28 of 31 checks passed
@18202781743 18202781743 deleted the sync-pr-252-nosync branch August 27, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants