Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorect window movement when selecting files #252

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

18202781743
Copy link
Contributor

@18202781743 18202781743 commented Aug 12, 2024

  • fix: 向日葵中点击文管窗口标题时直接进入移动窗口状态
  • fix: 共享库二进制兼容
  • fix: incorect window movement when selecting files

deepin-ci-robot added a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Aug 12, 2024
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#252
kegechen
kegechen previously approved these changes Aug 12, 2024
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 21, 2024

TAG Bot

New tag: 5.6.34
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #253

deepin-ci-robot added a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Aug 27, 2024
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#252
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 changed the title fix fix: incorect window movement when selecting files Aug 27, 2024
tanjingdong and others added 3 commits August 27, 2024 14:24
文管标题栏本身是可以击点拖动来移动窗口的,然后通过向日葵来点击(且没有move)时,
文管窗口会额外收到一个mouse move事件,于是就触发了移动窗口逻辑。
修改方法:
判断真实的mouse move距离,如果距离小于有效值就认为是无效的mouse move事件,不移动窗口。

Log: 修触发窗口移动条件
Bug: https://pms.uniontech.com/bug-view-261679.html
Influence: 窗口移动
共享库二进制兼容

Log: 共享库二进制兼容
Bug: https://pms.uniontech.com/bug-view-261679.html
deepin-ci-robot added a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Aug 27, 2024
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#252
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • DNoTitlebarWindowHelper::DNoTitlebarWindowHelper构造函数中,g_pressPoint.remove(this);可能会导致未处理的初始化问题,如果this已经在g_pressPoint中存在,则调用remove会失败。
  • DNoTitlebarWindowHelper::windowEvent函数中,g_pressPoint[this]的赋值操作应该在if语句块之外,以避免潜在的未初始化问题。
  • QPointF delta = me->globalPos() - g_pressPoint[this];计算了鼠标移动距离,但没有考虑到鼠标移动的累积效应,可能会导致在较短距离下误判移动事件。
  • if (delta.manhattanLength() < QGuiApplication::styleHints()->startDragDistance())中的QGuiApplication::styleHints()->startDragDistance()应该使用QApplication::startDragDistance(),因为QGuiApplication在Qt 6中已被移除。
  • self->isEnableSystemMove(winId)调用了一个未在更改前的代码中定义的函数isEnableSystemMove,需要确认该函数的存在性和作用。

是否建议立即修改:

@18202781743 18202781743 merged commit e2992ac into linuxdeepin:master Aug 27, 2024
19 of 20 checks passed
18202781743 pushed a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Aug 27, 2024
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants