Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pressing the power button opened the lock screen #637

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

zsien
Copy link
Member

@zsien zsien commented Jun 20, 2024

应该打开关机界面

Issues: linuxdeepin/developer-center#9360

@zsien zsien requested a review from a team June 20, 2024 02:21
Copy link

github-actions bot commented Jun 20, 2024

TAG Bot

TAG: 6.0.42
EXISTED: no
DISTRIBUTION: unstable

@zsien
Copy link
Member Author

zsien commented Jun 20, 2024

/topic dpidaemon

@deepin-ci-robot
Copy link

Add topic: dpidaemon successed.

@zsien
Copy link
Member Author

zsien commented Jun 20, 2024

/integr-topic dpidaemon

@deepin-ci-robot
Copy link

Integrated with pr deepin-community/Repository-Integration#1628

@zsien
Copy link
Member Author

zsien commented Jun 20, 2024

/topic ddcci-logoutSound-powerBtn

@deepin-ci-robot
Copy link

Add topic: ddcci-logoutSound-powerBtn successed.

@zsien
Copy link
Member Author

zsien commented Jun 20, 2024

/integr-topic ddcci-logoutSound-powerBtn

@deepin-ci-robot
Copy link

Integrated with pr deepin-community/Repository-Integration#1629

@zsien
Copy link
Member Author

zsien commented Jun 20, 2024

/integr-topic ddcci-logoutSound-powerBtn

@deepin-ci-robot
Copy link

Integrated with pr deepin-community/Repository-Integration#1629

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 21, 2024

TAG Bot

New tag: 6.0.41
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #634

@zsien
Copy link
Member Author

zsien commented Jun 21, 2024

/integr-topic ddcci-logoutSound-powerBtn

@deepin-ci-robot
Copy link

Integrated with pr deepin-community/Repository-Integration#1629

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 24, 2024

TAG Bot

New tag: 6.0.42
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #641

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Makefile中新增了cp -f misc/scripts/dde-shutdown.sh ${DESTDIR}${PREFIX}/lib/deepin-daemon/,需要确认这是否是有意为之,因为这可能会影响系统的安全性。
  • dde-lock.shdde-shutdown.sh脚本中的setxkbmap命令使用了-option选项,这可能会改变输入法的行为,需要确认这是否是预期的行为。
  • dde-lock.shdde-shutdown.sh脚本中的dbus-send命令使用了--print-reply选项,这可能会输出敏感信息,需要确保这些信息不会被意外地记录或泄露。
  • 新增的dde-shutdown.sh脚本中没有包含注释说明其用途和行为,这可能会导致其他开发者在阅读代码时产生困惑。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zsien zsien merged commit 299a422 into linuxdeepin:master Jul 24, 2024
14 of 16 checks passed
@zsien zsien deleted the zs/fix/shutdownscreen branch July 24, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants