nvme-print-json: update JSON verbose output for nvm-id-ctrl #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the nvme-id-ctrl JSON verbose output for parity with this command's normal verbose output. Signed-off-by: Martin George <[email protected]>
igaw
reviewed
Oct 4, 2024
| @@ -3072,6 +3072,15 @@ static void json_nvme_id_ctrl_nvm(struct nvme_id_ctrl_nvm *ctrl_nvm) | |||
| obj_add_uint64(r, "dmsl", le64_to_cpu(ctrl_nvm->dmsl)); | |||
| obj_add_uint(r, "aocs", le16_to_cpu(ctrl_nvm->aocs)); | |||
|
|
|||
| if (json_print_ops.flags & VERBOSE) { | |||
There was a problem hiding this comment.
I wonder if we should always print everything. For me the verbose flag makes only sense for the stdout output.
There was a problem hiding this comment.
I feel it helps. And also maintains consistency with the JSON verbose outputs of other basic commands such as list -v -o json , list-subsys -v -o json, etc.
There was a problem hiding this comment.
My point is that the json output could always print everything, no need make it short. Anyway, your change is fine, let's go with it, I ponder a bit if we should just kill the 'verbose' flag in the json output.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the nvme-id-ctrl JSON verbose output for parity with this command's normal verbose output.